Skip to content

Drop deprecated, type-specific options in favor of --type#336

Merged
rytilahti merged 2 commits intopython-kasa:masterfrom
rytilahti:janitor/drop_deprecated
Apr 6, 2022
Merged

Drop deprecated, type-specific options in favor of --type#336
rytilahti merged 2 commits intopython-kasa:masterfrom
rytilahti:janitor/drop_deprecated

Conversation

@rytilahti
Copy link
Copy Markdown
Member

Remove --plug, --bulb, --lightstrip, --strip. Use --type [type] instead.

Removes also passed but unused args.

@rytilahti rytilahti added the breaking change Breaking change label Apr 6, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 6, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.52%. Comparing base (6e988bd) to head (6b28124).
⚠️ Report is 802 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
- Coverage   80.99%   80.52%   -0.47%     
==========================================
  Files          25       25              
  Lines        1731     1715      -16     
  Branches      242      237       -5     
==========================================
- Hits         1402     1381      -21     
- Misses        287      300      +13     
+ Partials       42       34       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rytilahti rytilahti force-pushed the janitor/drop_deprecated branch from 06bceca to 6b28124 Compare April 6, 2022 01:21
@rytilahti rytilahti merged commit 631762b into python-kasa:master Apr 6, 2022
@rytilahti rytilahti deleted the janitor/drop_deprecated branch April 6, 2022 01:39
@rytilahti rytilahti mentioned this pull request Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants