Skip to content

Fix test_deprecated_type stalling#325

Merged
rytilahti merged 1 commit intopython-kasa:masterfrom
bdraco:slow_tests
Mar 24, 2022
Merged

Fix test_deprecated_type stalling#325
rytilahti merged 1 commit intopython-kasa:masterfrom
bdraco:slow_tests

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Mar 24, 2022

The tests were taking a long time to run because this wasn't patched out

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.41%. Comparing base (6f5a60a) to head (cf25c75).
⚠️ Report is 817 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   82.04%   82.41%   +0.36%     
==========================================
  Files          13       13              
  Lines        1376     1376              
  Branches      202      202              
==========================================
+ Hits         1129     1134       +5     
+ Misses        205      200       -5     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks 👍

@rytilahti rytilahti merged commit 2b05751 into python-kasa:master Mar 24, 2022
rytilahti pushed a commit that referenced this pull request Apr 5, 2022
* Fix test_deprecated_type stalling

* Fix strips with modularize

* Fix test_deprecated_type stalling (#325)
rytilahti pushed a commit that referenced this pull request Apr 5, 2022
* Fix test_deprecated_type stalling

* Fix strips with modularize

* Fix test_deprecated_type stalling (#325)
rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Apr 5, 2022
This release fixes an issue where the bulb state on led strips was not restored properly when turned back on.

[Full Changelog](python-kasa/python-kasa@0.4.2...0.4.3)

**Fixed bugs:**

- Divide by zero when HS300 powerstrip is discovered [\python-kasa#292](python-kasa#292)
- Ensure bulb state is restored when turning back on [\python-kasa#330](python-kasa#330) (@bdraco)

**Closed issues:**

- KL420L5 controls [\python-kasa#327](python-kasa#327)

**Merged pull requests:**

- Update pre-commit hooks to fix black in CI [\python-kasa#331](python-kasa#331) (@rytilahti)
- Fix test\_deprecated\_type stalling [\python-kasa#325](python-kasa#325) (@bdraco)
@rytilahti rytilahti mentioned this pull request Apr 5, 2022
rytilahti added a commit that referenced this pull request Apr 5, 2022
This release fixes an issue where the bulb state on led strips was not restored properly when turned back on.

[Full Changelog](0.4.2...0.4.3)

**Fixed bugs:**

- Divide by zero when HS300 powerstrip is discovered [\#292](#292)
- Ensure bulb state is restored when turning back on [\#330](#330) (@bdraco)

**Closed issues:**

- KL420L5 controls [\#327](#327)

**Merged pull requests:**

- Update pre-commit hooks to fix black in CI [\#331](#331) (@rytilahti)
- Fix test\_deprecated\_type stalling [\#325](#325) (@bdraco)
rytilahti pushed a commit that referenced this pull request Apr 5, 2022
* Fix test_deprecated_type stalling

* Fix strips with modularize

* Fix test_deprecated_type stalling (#325)
rytilahti pushed a commit that referenced this pull request Apr 5, 2022
* Fix test_deprecated_type stalling

* Fix strips with modularize

* Fix test_deprecated_type stalling (#325)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants