Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Smart (Tapo) fixture for the L530EA (EU) bulb and updates device classification and documentation so the test suite and supported-device lists recognize it.
Changes:
- Added a new SMART fixture file for L530EA(EU) on HW 1.0 / FW 1.4.2
- Updated test fixture model groupings to treat L530EA as a variable color temperature + color bulb
- Updated supported device documentation (README + SUPPORTED.md) to include L530EA
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/fixtures/smart/L530EA(EU)_1.0_1.4.2.json |
Adds SMART fixture data for the L530EA(EU) device to expand test coverage across supported models. |
tests/device_fixtures.py |
Includes L530EA in SMART bulb capability filters used by parametrized tests. |
SUPPORTED.md |
Documents tested HW/FW combo for L530EA under Tapo bulbs. |
README.md |
Updates the supported Tapo bulb model list to include L530EA. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1694 +/- ##
=======================================
Coverage 93.22% 93.22%
=======================================
Files 157 157
Lines 9815 9815
Branches 1003 1003
=======================================
Hits 9150 9150
Misses 472 472
Partials 193 193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add L530EA(EU) device fixture