Added KL125 and HS200 fixture dumps and updated tests to run on new format#160
Merged
rytilahti merged 3 commits intopython-kasa:masterfrom May 11, 2021
Conversation
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
=======================================
Coverage 74.42% 74.42%
=======================================
Files 11 11
Lines 1220 1220
Branches 177 177
=======================================
Hits 908 908
Misses 279 279
Partials 33 33 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conftest.pyto automatically include anyCOLOR_BULBSorVARIABLE_TEMPbulbs in theBULBSdevice set (I spent a good 10 minutes scratching my head on why I couldn't get this to work until I realized the convention used....this seems to make more sense to not accidentally omit a device type)newfakes.pyto safely skip over theemeterkey if it's not in the fixture dump (which it's not on the new fixtures added)