Skip to content

Do not crash on missing build number in fw version#1500

Merged
sdb9696 merged 5 commits intomasterfrom
fix/missing_rel_in_fwver
Feb 10, 2025
Merged

Do not crash on missing build number in fw version#1500
sdb9696 merged 5 commits intomasterfrom
fix/missing_rel_in_fwver

Conversation

@rytilahti
Copy link
Copy Markdown
Member

@rytilahti rytilahti commented Feb 9, 2025

Avoid parsing firmware version if it doesn't contain a whitespace (i.e., build number).

Fixes #1499

@rytilahti rytilahti added the bug Something isn't working label Feb 9, 2025
@rytilahti rytilahti mentioned this pull request Feb 9, 2025
Closed
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.66%. Comparing base (d5187dc) to head (cf165fc).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
kasa/iot/iotdevice.py 33.33% 1 Missing and 1 partial ⚠️
kasa/smartcam/smartcamchild.py 33.33% 1 Missing and 1 partial ⚠️
kasa/smartcam/smartcamdevice.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1500      +/-   ##
==========================================
- Coverage   92.71%   92.66%   -0.06%     
==========================================
  Files         150      150              
  Lines        9530     9538       +8     
  Branches      970      974       +4     
==========================================
+ Hits         8836     8838       +2     
- Misses        496      499       +3     
- Partials      198      201       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sdb9696
sdb9696 approved these changes Feb 9, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdb9696
Copy link
Copy Markdown
Collaborator

sdb9696 commented Feb 10, 2025 •
edited
Loading

I've updated this PR to treat the fixture as a modify to the existing 1.5.0, as I've confirmed it's exactly the same data (other than the fw_ver), and we don't currently treat the build number as a filename key (avoids two identical lines in SUPPORTED.md). Also fixed dump_devinfo as the get_temp_humidity_records call was not being made as part of the smartcam hub fixture generation.

EDIT: Also applied the same check for no build number to smartcam and iot devices.

@sdb9696 sdb9696 added this to the 0.10.2 milestone Feb 10, 2025
@sdb9696 sdb9696 enabled auto-merge (squash) February 10, 2025 11:11
@sdb9696 sdb9696 merged commit 668e32d into master Feb 10, 2025
@sdb9696 sdb9696 deleted the fix/missing_rel_in_fwver branch February 10, 2025 11:13
@rytilahti
Copy link
Copy Markdown
Member Author

rytilahti commented Feb 10, 2025

I was wondering if it'd be better to try-except on version parsing, but this works fine too. Thanks for fixing the CI & merging it! :-)

@sdb9696 sdb9696 mentioned this pull request Feb 12, 2025
Merged
sdb9696 added a commit that referenced this pull request Feb 12, 2025
@sdb9696
Prepare 0.10.2 (#1505)
f488492 
## [0.10.2](https://github.com/python-kasa/python-kasa/tree/0.10.2) (2025-02-12)

[Full Changelog](0.10.1...0.10.2)

**Release summary:**

- Bugfix for [#1499](#1499).
- Support for L530B and C110 devices.

**Fixed bugs:**

- H100 - Raised error: not enough values to unpack \(expected 2, got 1\) [\#1499](#1499)
- Do not crash on missing build number in fw version [\#1500](#1500) (@rytilahti)

**Added support for devices:**

- Add C110\(EU\) 2.0 1.4.3 fixture [\#1503](#1503) (@sdb9696)
- Add L530B\(EU\) 3.0 1.1.9 fixture [\#1502](#1502) (@sdb9696)

**Project maintenance:**

- Add fixtures for new versions of H100, P110, and T100 devices [\#1501](#1501) (@LXGaming)
- Add L530E\(TW\) 2.0 1.1.1 fixture [\#1497](#1497) (@bluehomewu)
rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Aug 31, 2025
@rytilahti @sdb9696
Do not crash on missing build number in fw version (python-kasa#1500)
62aa4aa 
Co-authored-by: Steven B <51370195+sdb9696@users.noreply.github.com>
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Aug 31, 2025
@sdb9696 @rytilahti
Prepare 0.10.2 (python-kasa#1505)
21fb7d9 
## [0.10.2](https://github.com/python-kasa/python-kasa/tree/0.10.2) (2025-02-12)

[Full Changelog](python-kasa/python-kasa@0.10.1...0.10.2)

**Release summary:**

- Bugfix for [python-kasa#1499](python-kasa#1499).
- Support for L530B and C110 devices.

**Fixed bugs:**

- H100 - Raised error: not enough values to unpack \(expected 2, got 1\) [\python-kasa#1499](python-kasa#1499)
- Do not crash on missing build number in fw version [\python-kasa#1500](python-kasa#1500) (@rytilahti)

**Added support for devices:**

- Add C110\(EU\) 2.0 1.4.3 fixture [\python-kasa#1503](python-kasa#1503) (@sdb9696)
- Add L530B\(EU\) 3.0 1.1.9 fixture [\python-kasa#1502](python-kasa#1502) (@sdb9696)

**Project maintenance:**

- Add fixtures for new versions of H100, P110, and T100 devices [\python-kasa#1501](python-kasa#1501) (@LXGaming)
- Add L530E\(TW\) 2.0 1.1.1 fixture [\python-kasa#1497](python-kasa#1497) (@bluehomewu)
rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Oct 26, 2025
@rytilahti @sdb9696
Do not crash on missing build number in fw version (python-kasa#1500)
cba142f 
Co-authored-by: Steven B <51370195+sdb9696@users.noreply.github.com>
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Oct 26, 2025
@sdb9696 @rytilahti
Prepare 0.10.2 (python-kasa#1505)
04b744b 
## [0.10.2](https://github.com/python-kasa/python-kasa/tree/0.10.2) (2025-02-12)

[Full Changelog](python-kasa/python-kasa@0.10.1...0.10.2)

**Release summary:**

- Bugfix for [python-kasa#1499](python-kasa#1499).
- Support for L530B and C110 devices.

**Fixed bugs:**

- H100 - Raised error: not enough values to unpack \(expected 2, got 1\) [\python-kasa#1499](python-kasa#1499)
- Do not crash on missing build number in fw version [\python-kasa#1500](python-kasa#1500) (@rytilahti)

**Added support for devices:**

- Add C110\(EU\) 2.0 1.4.3 fixture [\python-kasa#1503](python-kasa#1503) (@sdb9696)
- Add L530B\(EU\) 3.0 1.1.9 fixture [\python-kasa#1502](python-kasa#1502) (@sdb9696)

**Project maintenance:**

- Add fixtures for new versions of H100, P110, and T100 devices [\python-kasa#1501](python-kasa#1501) (@LXGaming)
- Add L530E\(TW\) 2.0 1.1.1 fixture [\python-kasa#1497](python-kasa#1497) (@bluehomewu)
rytilahti added a commit to rytilahti/python-kasa that referenced this pull request Nov 10, 2025
@rytilahti @sdb9696
Do not crash on missing build number in fw version (python-kasa#1500)
b32d330 
Co-authored-by: Steven B <51370195+sdb9696@users.noreply.github.com>
rytilahti pushed a commit to rytilahti/python-kasa that referenced this pull request Nov 10, 2025
@sdb9696 @rytilahti
Prepare 0.10.2 (python-kasa#1505)
d36cb72 
## [0.10.2](https://github.com/python-kasa/python-kasa/tree/0.10.2) (2025-02-12)

[Full Changelog](python-kasa/python-kasa@0.10.1...0.10.2)

**Release summary:**

- Bugfix for [python-kasa#1499](python-kasa#1499).
- Support for L530B and C110 devices.

**Fixed bugs:**

- H100 - Raised error: not enough values to unpack \(expected 2, got 1\) [\python-kasa#1499](python-kasa#1499)
- Do not crash on missing build number in fw version [\python-kasa#1500](python-kasa#1500) (@rytilahti)

**Added support for devices:**

- Add C110\(EU\) 2.0 1.4.3 fixture [\python-kasa#1503](python-kasa#1503) (@sdb9696)
- Add L530B\(EU\) 3.0 1.1.9 fixture [\python-kasa#1502](python-kasa#1502) (@sdb9696)

**Project maintenance:**

- Add fixtures for new versions of H100, P110, and T100 devices [\python-kasa#1501](python-kasa#1501) (@LXGaming)
- Add L530E\(TW\) 2.0 1.1.1 fixture [\python-kasa#1497](python-kasa#1497) (@bluehomewu)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdb9696 sdb9696 sdb9696 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

0.10.2

Development

Successfully merging this pull request may close these issues.

H100 - Raised error: not enough values to unpack (expected 2, got 1)

2 participants

@rytilahti @sdb9696