You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This modifies the discovery to query only system:get_sysinfo as querying multiple modules at once is known to have issues with some devices.
This PR also moves the dump-devinfo functionality to a separately shipped file under devtools, which should also now allow generating fixture files for devices that do not support querying multiple modules at once.
@rytilahti I finally had a chance to check out the dump_devinfo.py script that you mentioned in #141 and it was able to successfully dump information from my KL125 bulb and a new HS200 switch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the discovery to query only
system:get_sysinfoas querying multiple modules at once is known to have issues with some devices.This PR also moves the
dump-devinfofunctionality to a separately shipped file underdevtools, which should also now allow generating fixture files for devices that do not support querying multiple modules at once.Fixes #105, fixes #113, related to #120