fix(COPYING): Use the combined LGPGL and GPL license text.#3420
Open
JohnVillalovos wants to merge 1 commit into
Open
fix(COPYING): Use the combined LGPGL and GPL license text.#3420JohnVillalovos wants to merge 1 commit into
JohnVillalovos wants to merge 1 commit into
Conversation
Taken from https://www.gnu.org/licenses/lgpl-3.0.html in particular from https://www.gnu.org/licenses/lgpl+gpl-3.0.txt There is a bug in the https://github.com/gl-gitaly/go-license-detector where it only detects LGPL if the license contains both LGPL and GPL text in it. This bug causes the project to not be recognized as LGPL at GitLab. Discussed in: https://gitlab.com/gitlab-org/gitlab/-/work_items/543742 Related: #3395
There was a problem hiding this comment.
Pull request overview
Updates the repository’s COPYING license text to use the official combined LGPLv3 + GPLv3 wording, matching the GNU-provided lgpl+gpl-3.0.txt, to improve compatibility with GitLab’s (and go-license-detector’s) license detection and ensure the project is recognized as LGPL.
Changes:
- Replace the LGPLv3
COPYINGtext with the combined LGPLv3 + GPLv3 license text (as published by GNU). - Update the FSF URL in the copyright header from
http://tohttps://.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3420 +/- ##
==========================================
+ Coverage 90.32% 95.78% +5.46%
==========================================
Files 100 100
Lines 6172 6172
==========================================
+ Hits 5575 5912 +337
+ Misses 597 260 -337
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken from https://www.gnu.org/licenses/lgpl-3.0.html in particular from https://www.gnu.org/licenses/lgpl+gpl-3.0.txt
There is a bug in the https://github.com/gl-gitaly/go-license-detector where it only detects LGPL if the license contains both LGPL and GPL text in it.
This bug causes the project to not be recognized as LGPL at GitLab.
Discussed in: https://gitlab.com/gitlab-org/gitlab/-/work_items/543742
Related: #3395