Wrong annotation for Tags._fuzzy_search - #802
Closed
F4zii wants to merge 1 commit into
Closed
Conversation
The returned value from _fuzzy_search is a float The current type annotation is an int, solved this problem by switching it into a float
F4zii
requested review from
MrHemlock and
eivl
and removed request for
a team
February 29, 2020 06:56
Contributor
Contributor
|
Agreed. This doesn't need to be a separate pull request. In fact, this has already been addressed in the current version of #803, so I will just close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wrong annotation for Tags._fuzzy_search
The returned value from _fuzzy_search is a float
The current type annotation is an int,
solved this problem by switching it into a float
Resolves #789