Generalise attribute __func__ of class MethodType from FunctionType to Callable - #11201
Merged
Merged
Conversation
…ny]` instead of `_StaticFunctionType` and remove the latter.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
reviewed
Dec 28, 2023
srittau
left a comment
Collaborator
There was a problem hiding this comment.
The comment of _StaticFunctionType hints at an old (2017) mypy hack, although it seems the implementation also uses a member_descriptor class. Did you try just changing the return type of __get__ to a Callable?
Contributor
Author
|
No, I did not because from types import FunctionType
from typing import Any, Callable
class MethodType1:
@property
def __func__(self) -> FunctionType: ...
class MethodType2:
@property
def __func__(self) -> Callable[[...], Any]: ...
class Descriptor3:
def __get__(self, obj: object, type: type | None) -> FunctionType: ...
class MethodType3:
@property
def __func__(self) -> Descriptor3: ...
class Descriptor4:
def __get__(self, obj: object, type: type | None) -> Callable[[...], Any]: ...
class MethodType4:
@property
def __func__(self) -> Descriptor4: ...
reveal_type(MethodType1().__func__) # note: Revealed type is "types.MethodType"
reveal_type(MethodType2().__func__) # note: Revealed type is "def (Any) -> Any"
reveal_type(MethodType3().__func__) # note: Revealed type is "types.FunctionType"
reveal_type(MethodType4().__func__) # note: Revealed type is "def (Any) -> Any" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11200