Prevent crash on unpacking when tuple-returning overload is rejected by outer context - #19921
Closed
sterliakov wants to merge 2 commits into
Closed
Prevent crash on unpacking when tuple-returning overload is rejected by outer context#19921sterliakov wants to merge 2 commits into
sterliakov wants to merge 2 commits into
Conversation
…ted by outer context
sterliakov
force-pushed
the
bugfix/gh-19920-tuple-inference-crash
branch
from
September 24, 2025 16:44
ca1a2fc to
1bbdc0a
Compare
This comment has been minimized.
This comment has been minimized.
hauntsaninja
approved these changes
Jan 18, 2026
Collaborator
Author
|
@hauntsaninja please don't merge this one - as @ilevkivskyi suggested in the linked ticket, this might not be the right thing to do, and maybe overload selection process should ignore the outer context entirely. I tried to implement that - but the result was rather unsatisfactory (#20047), this probably needs some deeper investigation. |
sterliakov
marked this pull request as draft
January 18, 2026 22:56
Collaborator
|
Ah, that comment makes sense |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Member
|
Btw I likely will not have time to work on this soon, sorry. |
Member
|
(This means if anyone wanted to try a solution along the lines I suggested, please go ahead! :-)) |
pull Bot
pushed a commit
to Mu-L/mypy
that referenced
this pull request
Aug 10, 2026
Fixes python#21824 Fixes python#19920 Closes python#19921 Note that ilevkivskyi has a suggestion to change overload inference here: python#19920 (comment) While that is right, it is a little separate, and I think it is okay to remove the crash given that it now affects numpy and has been reported in other contexts too. We just keep the originally inferred tuple
hauntsaninja
added a commit
that referenced
this pull request
Aug 15, 2026
Fixes #21824 Fixes #19920 Closes #19921 Note that ilevkivskyi has a suggestion to change overload inference here: #19920 (comment) While that is right, it is a little separate, and I think it is okay to remove the crash given that it now affects numpy and has been reported in other contexts too. We just keep the originally inferred tuple
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19920. The removed assert was incorrect as demonstrated by the referenced issue - using additional inference context may change overload resolution outcomes, so no reasonable assumptions can be made about the reinferred type