Skip to content

Mention typo fixes and large PRs#1782

Merged
willingc merged 7 commits intopython:mainfrom
johnslavik:gh-1448-typo-fixes-section
Apr 20, 2026
Merged

Mention typo fixes and large PRs#1782
willingc merged 7 commits intopython:mainfrom
johnslavik:gh-1448-typo-fixes-section

Conversation

@johnslavik
Copy link
Copy Markdown
Member

@johnslavik johnslavik commented Apr 15, 2026

Closes #1448

Add guidance on keeping typo-fix PRs small and focused, listing
appropriate directories (Doc/, Misc/, Misc/NEWS.d/) and noting
that large sweeping PRs may be closed.
- Clarify which directories are appropriate for typo fixes
- Encourage small, focused PRs to reduce reviewer notification burden
- Explicitly note that large PRs or PRs outside listed directories
  may be closed with a reference to this section
@johnslavik johnslavik requested review from hugovk and willingc April 15, 2026 10:09
@johnslavik johnslavik self-assigned this Apr 15, 2026
@read-the-docs-community
Copy link
Copy Markdown

read-the-docs-community bot commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnslavik. Please leave a brief note in the PR submission message what prompted you to propose these devguide changes. I do think that this is a useful addition. ☀️

Comment thread getting-started/pull-request-lifecycle.rst Outdated
Comment thread getting-started/pull-request-lifecycle.rst Outdated
Comment thread getting-started/pull-request-lifecycle.rst Outdated
Comment thread getting-started/pull-request-lifecycle.rst Outdated
Comment thread getting-started/pull-request-lifecycle.rst
Comment thread getting-started/pull-request-lifecycle.rst Outdated
johnslavik and others added 3 commits April 20, 2026 03:56
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>

Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
@johnslavik
Copy link
Copy Markdown
Member Author

Thanks for the quick feedback! @willingc, forgot to link to #1448. I've been meaning to write this section since python/cpython#144242.

Copy link
Copy Markdown
Collaborator

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @johnslavik 🚀 Happy to merge.

@willingc willingc merged commit 1cda41a into python:main Apr 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a section on typo fixes and large PRs

4 participants