Skip to content

gh-87799: Improve the textual representation of IPv4-mapped IPv6 addresses #29345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asvetlov merged 13 commits into from
Jul 31, 2023
+45 −1
Merged

gh-87799: Improve the textual representation of IPv4-mapped IPv6 addresses #29345

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3407d76
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 31, 2021
118e335
bpo-43633 Improve the textual representation of IPv4-mapped IPv6 addr…
opavlyuk Apr 13, 2023
f3642ca
bpo-43633 Update tests
opavlyuk Apr 13, 2023
669cc90
bpo-43633 Fix tests
opavlyuk Apr 13, 2023
8be267a
Merge branch 'main' into fix-issue-43633
opavlyuk Apr 13, 2023
4e7ad6b
Merge branch 'main' into fix-issue-43633
asvetlov Jul 27, 2023
c2842ce
Add failed test
asvetlov Jul 31, 2023
a06e745
Merge branch 'main' into fix-issue-43633
asvetlov Jul 31, 2023
97bd01c
User shorter variable names
asvetlov Jul 31, 2023
2d2deea
Revert test back
asvetlov Jul 31, 2023
105d82a
Merge branch 'main' into fix-issue-43633
asvetlov Jul 31, 2023
e8a7015
Update 2021-10-31-16-06-28.bpo-43633.vflwXv.rst
asvetlov Jul 31, 2023
d74759b
Update 2021-10-31-16-06-28.bpo-43633.vflwXv.rst
asvetlov Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
User shorter variable names
  • Loading branch information
@asvetlov
asvetlov committed Jul 31, 2023
commit 97bd01cabc4a1d054beb9d0e355217f8c505a2da
14 changes: 7 additions & 7 deletions Lib/test/test_ipaddress.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1325,13 +1325,13 @@ def testIPv6IPv4MappedStringRepresentation(self):
long_prefix = '0000:0000:0000:0000:0000:ffff:'
ipv4 = '1.2.3.4'
for short_prefix in ('::ffff:', '::'):
ipv6_ipv4_mapped_str = '%s%s' % (short_prefix, ipv4)
with self.subTest(addr=ipv6_ipv4_mapped_str):
ipv6_ipv4_mapped_address = ipaddress.IPv6Address(ipv6_ipv4_mapped_str)
ipv6_ipv4_mapped_interface = ipaddress.IPv6Interface(ipv6_ipv4_mapped_str)
self.assertEqual(str(ipv6_ipv4_mapped_address), ipv6_ipv4_mapped_str)
self.assertEqual(ipv6_ipv4_mapped_address.exploded, long_prefix + ipv4)
self.assertEqual(str(ipv6_ipv4_mapped_interface.ip), ipv6_ipv4_mapped_str)
ipv6_ipv4_str = '%s%s' % (short_prefix, ipv4)
with self.subTest(addr=ipv6_ipv4_str):
ipv6_ipv4_addr = ipaddress.IPv6Address(ipv6_ipv4_str)
ipv6_ipv4_iface = ipaddress.IPv6Interface(ipv6_ipv4_str)
self.assertEqual(str(ipv6_ipv4_addr), ipv6_ipv4_str)
self.assertEqual(ipv6_ipv4_addr.exploded, long_prefix + ipv4)
self.assertEqual(str(ipv6_ipv4_iface.ip), ipv6_ipv4_str)

def testGetScopeId(self):
self.assertEqual(self.ipv6_address.scope_id,
Expand Down