Skip to content

bpo-43625: Enhance csv sniffer has_headers() to be more accurate#26939

Merged
ambv merged 9 commits into
python:mainfrom
akulakov:43625-Csv-sniffer-enhancement
Jul 30, 2021
Merged

bpo-43625: Enhance csv sniffer has_headers() to be more accurate#26939
ambv merged 9 commits into
python:mainfrom
akulakov:43625-Csv-sniffer-enhancement

Conversation

@akulakov

@akulakov akulakov commented Jun 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Based on the patch by @smontanaro , updated by A. Kulakov

https://bugs.python.org/issue43625

@akulakov akulakov marked this pull request as draft June 29, 2021 02:51
smontanaro
smontanaro reviewed Jun 29, 2021
View reviewed changes
Comment thread Lib/test/test_csv.py Outdated
@akulakov akulakov marked this pull request as ready for review June 29, 2021 13:55
smontanaro
smontanaro reviewed Jun 29, 2021
View reviewed changes
Comment thread Lib/csv.py Outdated
@smontanaro

smontanaro commented Jun 29, 2021

Copy link
Copy Markdown
Contributor

I added one niggling comment, but otherwise LGTM.

@akulakov

akulakov commented Jun 29, 2021

Copy link
Copy Markdown
Contributor Author

@smontanaro thanks for the review!, - updated to catch specific exceptions..

@github-actions

github-actions Bot commented Jul 30, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jul 30, 2021
@ambv ambv added the needs backport to 3.10 only security fixes label Jul 30, 2021
@ambv ambv merged commit ceea579 into python:main Jul 30, 2021
@miss-islington

miss-islington commented Jul 30, 2021

Copy link
Copy Markdown
Contributor

Thanks @akulakov for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 30, 2021
@akulakov @miss-islington
bpo-43625: Enhance csv sniffer has_headers() to be more accurate (pyt…
dbbb9f2 
…honGH-26939)

(cherry picked from commit ceea579)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@bedevere-bot

bedevere-bot commented Jul 30, 2021

Copy link
Copy Markdown

GH-27494 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 30, 2021
ambv pushed a commit that referenced this pull request Jul 30, 2021
@miss-islington @akulakov
bpo-43625: Enhance csv sniffer has_headers() to be more accurate (GH-…
440c9f7 
…26939) (GH-27494)

(cherry picked from commit ceea579)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@smontanaro smontanaro smontanaro left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@akulakov @smontanaro @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni