Skip to content

bpo-39075: types.SimpleNamespace no longer sorts attributes in its repr#19430

Merged
miss-islington merged 3 commits into
python:masterfrom
ZackerySpytz:bpo-39075-SimpleNamespace-ordering
May 16, 2020
Merged

bpo-39075: types.SimpleNamespace no longer sorts attributes in its repr#19430
miss-islington merged 3 commits into
python:masterfrom
ZackerySpytz:bpo-39075-SimpleNamespace-ordering

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Apr 8, 2020 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

CuriousLearner
CuriousLearner reviewed Apr 18, 2020
View reviewed changes

@CuriousLearner CuriousLearner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment. Overall the changes look okay to me.

Comment thread Doc/library/types.rst Outdated
ericsnowcurrently
ericsnowcurrently requested changes May 12, 2020
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.

I left a few comments about phrasing in the docs and NEWS entry.

Comment thread Doc/library/types.rst Outdated
Comment thread Doc/library/types.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2020-04-07-23-44-06.bpo-39075.hgck3j.rst Outdated
@bedevere-bot

bedevere-bot commented May 12, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ZackerySpytz

ZackerySpytz commented May 13, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented May 13, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@ericsnowcurrently: please review the changes made to this pull request.

CuriousLearner
CuriousLearner approved these changes May 13, 2020
View reviewed changes

@CuriousLearner CuriousLearner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

ericsnowcurrently
ericsnowcurrently approved these changes May 16, 2020
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. LGTM

@miss-islington miss-islington merged commit 6b6092f into python:master May 16, 2020
arturoescaip pushed a commit to arturoescaip/cpython that referenced this pull request May 24, 2020
@ZackerySpytz @arturoescaip
bpo-39075: types.SimpleNamespace no longer sorts attributes in its re…
00a75c1 
…pr (pythonGH-19430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi left review comments
@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes
@CuriousLearner CuriousLearner CuriousLearner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ZackerySpytz @bedevere-bot @ericsnowcurrently @tirkarthi @CuriousLearner @the-knights-who-say-ni @miss-islington