Skip to content

gh-155496: Use Argument Clinic for more functions of the time module #155513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serhiy-storchaka wants to merge 5 commits into
base: main
Choose a base branch
from
+975 −243
Open

gh-155496: Use Argument Clinic for more functions of the time module #155513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
01086a8
gh-155496: Use Argument Clinic for more functions of the time module
serhiy-storchaka Aug 10, 2026
ed893d6
Update test_inspect for the new signatures
serhiy-storchaka Aug 13, 2026
4108372
Fix test_autospec_on_bound_builtin_function
serhiy-storchaka Aug 13, 2026
ca3e771
Use a function which is defined without a signature
serhiy-storchaka Aug 13, 2026
b10998e
Address review comments
serhiy-storchaka Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions Lib/test/test_inspect/test_inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6359,15 +6359,10 @@ def test_thread_module_has_signatures(self):
self._test_module_has_signatures(_thread, no_signature)

def test_time_module_has_signatures(self):
no_signature = {
'asctime', 'ctime', 'get_clock_info', 'gmtime', 'localtime',
'strftime', 'strptime'
}
no_signature |= {name for name in
['clock_getres', 'clock_settime', 'clock_settime_ns',
'pthread_getcpuclockid']
if hasattr(time, name)}
self._test_module_has_signatures(time, no_signature)
no_signature = {'strftime', 'strptime'}
unsupported_signature = {'asctime'}
self._test_module_has_signatures(time, no_signature,
unsupported_signature)

def test_tokenize_module_has_signatures(self):
import tokenize
Expand Down
9 changes: 6 additions & 3 deletions Lib/test/test_unittest/testmock/testhelpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import inspect
import time
import types
import unittest

from test.support import import_helper

from unittest.mock import (
call, _Call, create_autospec, MagicMock,
Mock, ANY, _CallList, patch, PropertyMock, _callable
Expand Down Expand Up @@ -929,8 +930,10 @@ def check_data_descriptor(mock_attr):


def test_autospec_on_bound_builtin_function(self):
meth = types.MethodType(time.ctime, time.time())
self.assertIsInstance(meth(), str)
_testcapi = import_helper.import_module('_testcapi')
# This function is defined without a signature.
meth = types.MethodType(_testcapi.docstring_no_signature, object())
self.assertIsNone(meth())
mocked = create_autospec(meth)

# no signature, so no spec to check against
Expand Down
Loading
Loading