gh-151408: Re-register submodules in sys.modules on lazy re-import#151411
Closed
bhuvi27 wants to merge 1 commit into
Closed
gh-151408: Re-register submodules in sys.modules on lazy re-import#151411bhuvi27 wants to merge 1 commit into
bhuvi27 wants to merge 1 commit into
Conversation
When a submodule is removed from sys.modules but still cached on its parent package, lazy import reification returned the stale module without restoring sys.modules. Register the module again when import or attribute lookup resolves a submodule whose __name__ matches.
Member
|
Closing in favor of #151412 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151408
Deleting a submodule from sys.modules and then re-resolving it via lazy import returned the module object still cached on the parent package but did not put it back in sys.modules.
Register the submodule in sys.modules again when import-from or module getattr finds it on the parent and its name matches. Tests in test_lazy_import.