gh-151218: Replace sys.flags in PyConfig_Set()#151402
Open
vstinner wants to merge 1 commit into
Open
Conversation
PyConfig_Set() and sys.set_int_max_str_digits() now replace sys.flags, instead of modifying sys.flags in-place. Modifying sys.flags in-place can lead to data races when multiple threads are reading or writing sys.flags in parallel. Use _Py_atomic functions to get and set max_str_digits members.
Member
Author
|
I built Python with If we agree that this change is the right approach, I will add a non-regression test. |
skirpichev
reviewed
Jun 12, 2026
skirpichev
left a comment
Member
There was a problem hiding this comment.
I think it's a correct approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyConfig_Set() and sys.set_int_max_str_digits() now replace sys.flags, instead of modifying sys.flags in-place.
Modifying sys.flags in-place can lead to data races when multiple threads are reading or writing sys.flags in parallel.
Use _Py_atomic functions to get and set max_str_digits members.
sys_set_flagwhensys.set_int_max_str_digits()is called concurrently with free-threaded build #151218