gh-146578: _zstd: Fix printf format for pledged size errors#146576
gh-146578: _zstd: Fix printf format for pledged size errors#146576emmatyping merged 1 commit intopython:mainfrom
Conversation
Use %llu instead of %ull for unsigned long long in zstd_contentsize_converter ValueError messages.
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Good catch! Could you please add tests?
Most likely there are already tests for passing out of range size argument, but they do not test the error message or the test is too lenient. You can change ValueError to something other, like SystemError, run the test and look what fails.
|
Inspired by this, I wrote a plugin to capture similar issues. Are you guys interested? I can open a new issue. |
I would say if you find issues similar to this one those are likely bugs so you should open a new issue. Good idea to do this analysis! |
|
If you do find similar issues, just open a single issue. You can open multiple PRs for that same issue though. |
|
If you found other similar bugs, they should be fixed. I doubt similar bugs will occur on regular basis. |
|
Thanks @cuiweixie for the PR, and @emmatyping for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
GH-148855 is a backport of this pull request to the 3.14 branch. |
Summary
Replace invalid
%ullwith%lluinzstd_contentsize_converterValueErrorformat strings. The correct specifier for
unsigned long longis%llu.Test plan
_zstd; change affects error-message formatting only.