Skip to content

bpo-37483: fix refleak #14599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
methane wants to merge 2 commits into from
Closed

bpo-37483: fix refleak #14599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13f2d92
bpo-37483: fix refleak
methane Jul 5, 2019
2aab061
move variable declaration
methane Jul 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Python/codecs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ PyObject *normalizestring(const char *string)

PyObject *_PyCodec_Lookup(const char *encoding)
{
PyObject *result, *v;
PyObject *result;
Py_ssize_t i, len;

if (encoding == NULL) {
Expand All @@ -114,7 +114,7 @@ PyObject *_PyCodec_Lookup(const char *encoding)
/* Convert the encoding to a normalized Python string: all
characters are converted to lower case, spaces and hyphens are
replaced with underscores. */
v = normalizestring(encoding);
PyObject *v = normalizestring(encoding);
if (v == NULL)
goto onError;
PyUnicode_InternInPlace(&v);
Expand Down Expand Up @@ -175,9 +175,11 @@ PyObject *_PyCodec_Lookup(const char *encoding)
Py_DECREF(result);
goto onError;
}
Py_DECREF(v);
return result;

onError:
Py_DECREF(v);
return NULL;
}

Expand Down