Skip to content

gh-128715: CTypeField: Put intness, signedness and pointerness in flags #138541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
encukou wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-128715: CTypeField: Put intness, signedness and pointerness in flags #138541

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
249dda0
Put intness, signedness and pointerness in flags
encukou Dec 20, 2024
e6f593e
Remove local uses of _ctypes_get_fielddesc; use the functions directly
encukou Jan 9, 2025
fead2f1
Use the TYPEFLAG_IS_INTEGER flag
encukou Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use the TYPEFLAG_IS_INTEGER flag
  • Loading branch information
@encukou
encukou committed Sep 5, 2025
commit fead2f1f62fd3f02ff27883ebf77fb7719c74bf4
31 changes: 10 additions & 21 deletions Modules/_ctypes/cfield.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ Py_ssize_t NUM_BITS(Py_ssize_t bitsize);
static inline
Py_ssize_t LOW_BIT(Py_ssize_t offset);


/*[clinic input]
@classmethod
_ctypes.CField.__new__ as PyCField_new
Expand Down Expand Up @@ -114,26 +113,16 @@ PyCField_new_impl(PyTypeObject *type, PyObject *name, PyObject *proto,
Py_ssize_t bit_offset = 0;
if (bit_size_obj != Py_None) {
// It's a bit field!
switch(info->ffi_type_pointer.type) {
case FFI_TYPE_UINT8:
case FFI_TYPE_UINT16:
case FFI_TYPE_UINT32:
case FFI_TYPE_SINT64:
case FFI_TYPE_UINT64:
break;

case FFI_TYPE_SINT8:
case FFI_TYPE_SINT16:
case FFI_TYPE_SINT32:
if (info->getfunc != c_get && info->getfunc != u_get) {
break;
}
_Py_FALLTHROUGH; /* else fall through */
default:
PyErr_Format(PyExc_TypeError,
"bit fields not allowed for type %s",
((PyTypeObject*)proto)->tp_name);
goto error;
if (
!(info->flags & TYPEFLAG_IS_INTEGER)
|| info->getfunc == c_get
|| info->getfunc == u_get
) {
PyErr_Format(
PyExc_TypeError,
"bit fields not allowed for type %s",
((PyTypeObject*)proto)->tp_name);
goto error;
}

if (byte_size > 100) {
Expand Down
Loading