gh-136601: Always set TarInfo.size to the real file size for sparse files#136622
Open
mxmlnkn wants to merge 1 commit into
Open
gh-136601: Always set TarInfo.size to the real file size for sparse files#136622mxmlnkn wants to merge 1 commit into
TarInfo.size to the real file size for sparse files#136622mxmlnkn wants to merge 1 commit into
Conversation
OBITOONDEADO1MZ
approved these changes
Jul 13, 2025
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt to fix #136601.
offset_databeing used for sparse files with an additionalsizePAX keyword #136621 because it would make my case even worse, because the TAR offset recomputation would use the real file size instead of the TAR data size.Lib/test/archivetestdata/and add a test intoLib/test/test_tarfile.py? The test setup seems a bit complicated. I'm unsure whether I would do it the right way. That reproducer would be a test case for both bugs / pull requests.sizeandGNU.sparse.realsizekeys at the same time #136601