Skip to content

[3.14] gh-132775: Unrevert "Add _PyCode_VerifyStateless()" #133625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 5 commits into from
May 8, 2025
Merged

[3.14] gh-132775: Unrevert "Add _PyCode_VerifyStateless()" #133625

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eab4c13
Revert "gh-132775: Revert "gh-132775: Add _PyCode_VerifyStateless() (…
ericsnowcurrently May 6, 2025
c36747c
Relax the constraints in _PyCode_CheckNoInternalState().
ericsnowcurrently May 6, 2025
b943bb0
Add a test for co_extra.
ericsnowcurrently May 6, 2025
bcc081b
Drop _testinternalcapi.code_set_co_extra().
ericsnowcurrently May 6, 2025
2873383
Fix a typo.
ericsnowcurrently May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Relax the constraints in _PyCode_CheckNoInternalState().
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed May 6, 2025
commit c36747cd1a8a4b80656ff36a08025d6dc3458ac1
10 changes: 3 additions & 7 deletions Objects/codeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1959,13 +1959,9 @@ int
_PyCode_CheckNoInternalState(PyCodeObject *co, const char **p_errmsg)
{
const char *errmsg = NULL;
if (_PyCode_HAS_EXECUTORS(co) || _PyCode_HAS_INSTRUMENTATION(co)) {
errmsg = "only basic code objects are supported";
}
else if (co->_co_monitoring != NULL) {
errmsg = "only basic code objects are supported";
}
else if (co->co_extra != NULL) {
// We don't worry about co_executors, co_instrumentation,
// or co_monitoring. They are essentially ephemeral.
if (co->co_extra != NULL) {
errmsg = "only basic code objects are supported";
}

Expand Down