Skip to content

gh-132776: Cleanup for XIBufferViewType#132821

Merged
ericsnowcurrently merged 5 commits into
python:mainfrom
ericsnowcurrently:xibufferview-cleanup
Apr 25, 2025
Merged

gh-132776: Cleanup for XIBufferViewType#132821
ericsnowcurrently merged 5 commits into
python:mainfrom
ericsnowcurrently:xibufferview-cleanup

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Apr 23, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member
  • add notes
  • rename XIBufferViewObject to xibufferview
  • move memoryview XIData code to memoryobject.c

@bedevere-app bedevere-app Bot mentioned this pull request Apr 23, 2025
Closed
@ericsnowcurrently ericsnowcurrently merged commit e54e828 into python:main Apr 25, 2025
@ericsnowcurrently ericsnowcurrently deleted the xibufferview-cleanup branch April 25, 2025 00:25
@vstinner

vstinner commented Apr 25, 2025

Copy link
Copy Markdown
Member

This change introduced memory leaks. Examples:

$ ./python -m test test__interpchannels -R 3:3 -m test_send_buffer_blocking_waiting
...
test__interpchannels leaked [2, 2, 2] references, sum=6
...

$ ./python -m test test_interpreters -R 3:3 -m test_from_subinterpreter
...
test_interpreters leaked [11, 11, 11] references, sum=33
test_interpreters leaked [9, 9, 9] memory blocks, sum=27
...

@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 25, 2025
Merged
@ericsnowcurrently

ericsnowcurrently commented Apr 25, 2025

Copy link
Copy Markdown
Member Author

I've created a PR with a fix: gh-132960.

ericsnowcurrently added a commit that referenced this pull request Apr 25, 2025
@ericsnowcurrently
gh-132776: Revert Moving memoryview XIData Code to memoryobject.c (gh…
2a28b21 
…-132960)

This is a partial revert of gh-132821.  It resolves the refleak introduced by that PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericsnowcurrently @vstinner