gh-89745: Remove dead realpath branch in getpath.c#128861
Closed
pelson wants to merge 1 commit intopython:mainfrom
Closed
gh-89745: Remove dead realpath branch in getpath.c#128861pelson wants to merge 1 commit intopython:mainfrom
pelson wants to merge 1 commit intopython:mainfrom
Conversation
…s taking precedence
Contributor
Author
|
It looks like this came in part in 99fcf15#diff-ad0a6e4fd367f158f5af826b512704cef7808813c3a3a474f9d8a10b5ef75e45. |
Contributor
Author
This comment was marked as resolved.
This comment was marked as resolved.
Member
Me neither. I'm not confident to remove code that I copy-pasted (I assume from |
|
This PR is stale because it has been open for 30 days with no activity. |
Member
|
Closing as we are not entirely sure it is really a dead path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The readlink code before is always taking precedence, and I don't know of a platform which has realpath but not readlink.
Note that this is a bit of a speculative change identified when tackling another getpath[.py] issue - I have no broad knowledge of platforms to be 100% certain that realpath without readlink isn't a thing.