gh-127335: Add TIOCM_OUT1, TIOCM_OUT2, and TIOCM_LOOP to termios#127336
Open
rruuaanng wants to merge 3 commits intopython:mainfrom
Open
gh-127335: Add TIOCM_OUT1, TIOCM_OUT2, and TIOCM_LOOP to termios#127336rruuaanng wants to merge 3 commits intopython:mainfrom
TIOCM_OUT1, TIOCM_OUT2, and TIOCM_LOOP to termios#127336rruuaanng wants to merge 3 commits intopython:mainfrom
Conversation
ZeroIntensity
approved these changes
Nov 28, 2024
Member
ZeroIntensity
left a comment
There was a problem hiding this comment.
Thanks! LGTM.
As far as I can tell, we don't have explicit tests or documentation for any of the other macros, so I think we're good.
TIOCM_OUT1, TIOCM_OUT2, and TIOCM_LOOP to termios
erlend-aasland
approved these changes
Nov 29, 2024
Contributor
|
As you've been told previously, please spell out the actual change in the PR title. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TIOCM_OUT1,TIOCM_OUT2, andTIOCM_LOOPconstants totermios#127335Mainly synchronize the latest modem lines constants to the
termiosmodule.