Skip to content

gh-114940: Use fine-grained mutex protection for PyInterpreterState.threads #125561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rruuaanng wants to merge 27 commits into from
Closed

gh-114940: Use fine-grained mutex protection for PyInterpreterState.threads #125561

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
414cfef
Add threads.mutex member to PyInterpreState
rruuaanng Oct 16, 2024
0c815fc
Add NEWS
rruuaanng Oct 16, 2024
f5ec949
Delete Misc/NEWS.d/next/Core_and_Builtins/2024-10-16-11-07-50.gh-issu…
rruuaanng Oct 16, 2024
b595153
Change to current thread mutex
rruuaanng Oct 17, 2024
2378caa
Remove runtime variable
rruuaanng Oct 17, 2024
9cb2de0
HEAD_LOCK change to INTERP_THREAD_LOCK
rruuaanng Oct 17, 2024
afbaf04
Merge branch 'main' into _gh114940
rruuaanng Oct 17, 2024
29c4ccb
HEAD_LOCK change to INTERP_THREAD_LOCK
rruuaanng Oct 17, 2024
462f97d
HEAD_LOCK change to INTERP_THREAD_LOCK
rruuaanng Oct 18, 2024
8146b6f
Remove unused variable
rruuaanng Oct 18, 2024
74cc060
Clear unused code
rruuaanng Oct 18, 2024
f30b2b1
Change comment
rruuaanng Oct 19, 2024
8e0d324
INTERP_THREAD_LOCK rename to INTERP_HEAD_LOCK
rruuaanng Oct 19, 2024
1f488c7
INTERP_THREAD_LOCK rename to INTERP_HEAD_LOCK
rruuaanng Oct 19, 2024
c99e44e
INTERP_THREAD_LOCK rename to INTERP_HEAD_LOCK
rruuaanng Oct 19, 2024
7ad9c32
Using raw member
rruuaanng Oct 19, 2024
2131d69
Fix possible race conditions
rruuaanng Oct 19, 2024
7bf9a1c
INTERP_THREAD_LOCK rename to INTERP_HEAD_LOCK
rruuaanng Oct 19, 2024
b947bc9
Rollback to unmodified
rruuaanng Oct 20, 2024
46c2709
Use variable
rruuaanng Oct 20, 2024
3c208c2
Recover assert
rruuaanng Oct 24, 2024
2bb60d9
Add mutex for get_mimalloc_allocated_blocks
rruuaanng Oct 24, 2024
3798bed
Add mutex for get_reftotal
rruuaanng Oct 24, 2024
5dc1ced
Merge branch 'main' into _gh114940
rruuaanng Nov 2, 2024
18fbaa0
Merge branch 'main' into _gh114940
rruuaanng Nov 20, 2024
6257837
add lock to codeobject
rruuaanng Nov 20, 2024
4b9a569
clear ci warning
rruuaanng Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clear unused code
  • Loading branch information
@rruuaanng
rruuaanng committed Oct 18, 2024
commit 74cc0605617356c89c5b7de4c94440c66cc788fc
7 changes: 0 additions & 7 deletions Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1847,13 +1847,6 @@ _PyThreadState_RemoveExcept(PyThreadState *tstate)
{
assert(tstate != NULL);
PyInterpreterState *interp = tstate->interp;
_PyRuntimeState *runtime = interp->runtime;

#ifdef Py_GIL_DISABLED
assert(runtime->stoptheworld.world_stopped);
#else
assert(runtime != NULL);
#endif

INTERP_THREAD_LOCK(interp);
/* Remove all thread states, except tstate, from the linked list of
Expand Down