Skip to content

GH-118093: Don't lose confidence when tracing through 100% biased branches #124813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 5 commits into from
Oct 2, 2024
Merged

GH-118093: Don't lose confidence when tracing through 100% biased branches #124813

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b40e19
Use Laplace's rule of succession for trace confidence
brandtbucher Sep 6, 2024
130eede
Clarify exact value
brandtbucher Sep 6, 2024
18cf547
Don't assume the future is uncertain
brandtbucher Sep 7, 2024
6c156af
blurb add
brandtbucher Sep 30, 2024
4e14b5c
Remove weird comment
brandtbucher Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use Laplace's rule of succession for trace confidence
  • Loading branch information
@brandtbucher
brandtbucher committed Sep 30, 2024
commit 8b40e192e3153240a3ed16fc0fcc7fb6b941d057
9 changes: 5 additions & 4 deletions Python/optimizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,14 +643,15 @@ translate_bytecode_to_trace(
int bitcount = _Py_popcount32(counter);
int jump_likely = bitcount > 8;
/* If bitcount is 8 (half the jumps were taken), adjust confidence by 50%.
If it's 16 or 0 (all or none were taken), adjust by 10%
(since the future is still somewhat uncertain).
If it's 16 or 0 (all or none were taken), adjust by ~6%
(since the future is still somewhat uncertain - see Laplace's
rule of succession, used here with 16 observations).
For values in between, adjust proportionally. */
if (jump_likely) {
confidence = confidence * (bitcount + 2) / 20;
confidence = confidence * (bitcount + 1) / 18;
}
else {
confidence = confidence * (18 - bitcount) / 20;
confidence = confidence * (17 - bitcount) / 18;
}
uint32_t uopcode = BRANCH_TO_GUARD[opcode - POP_JUMP_IF_FALSE][jump_likely];
DPRINTF(2, "%d: %s(%d): counter=%04x, bitcount=%d, likely=%d, confidence=%d, uopcode=%s\n",
Expand Down