gh-123309: Add more tests for the pickletools module - #123355
Merged
Merged
Conversation
Add tests for genops() and dis().
birkenfeld
approved these changes
Aug 31, 2024
|
|
||
| def read(self, n): | ||
| data = self.data[self.pos: self.pos + n] | ||
| self.pos += n |
Member
There was a problem hiding this comment.
Probably not applicable, but what if self.pos+n < len(self.data)?
Member
Author
There was a problem hiding this comment.
You perhaps mean self.pos+n > len(self.data)? We will get truncated data, and the following reads will return an empty bytes object. Like in real files or BytesIO.
SimpleReader is not currently used in such tests, because it does not make difference, but I am sure that tests for truncated data would pass with it.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 31, 2024
|
GH-123533 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 31, 2024
|
GH-123534 is a backport of this pull request to the 3.12 branch. |
Yhg1s
pushed a commit
that referenced
this pull request
Sep 2, 2024
ambv
pushed a commit
that referenced
this pull request
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for genops() and dis().