Skip to content

GH-122155: Track local variables between pops and pushes in cases generator #122286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 13 commits into from
Aug 1, 2024
Merged

GH-122155: Track local variables between pops and pushes in cases generator #122286

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d507013
Track local variables between pops and pushes in cases generator
markshannon Jul 25, 2024
2cc8758
Add test and update test
markshannon Jul 25, 2024
624bc50
Handle ERROR_IF properly for complex stacks
markshannon Jul 25, 2024
accf9e9
Fix type annotations
markshannon Jul 25, 2024
1eea271
Merge branch 'main' into cases-gen-track-locals
markshannon Jul 25, 2024
1ca17fb
Remove unreachable code
markshannon Jul 25, 2024
56e9afb
Merge branch 'main' into cases-gen-track-locals
markshannon Jul 26, 2024
47f3bb3
Apply suggestions from code review
markshannon Jul 30, 2024
89fbf03
Use dict and tuple instead of Dict and Tuple in annotations
markshannon Jul 30, 2024
76a364f
Minor tidy up
markshannon Jul 30, 2024
070786d
Merge branch 'main' into cases-gen-track-locals
markshannon Jul 30, 2024
d7a4c07
Add clarifying comment
markshannon Jul 31, 2024
a748da3
Merge branch 'main' into cases-gen-track-locals
markshannon Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor tidy up
  • Loading branch information
@markshannon
markshannon committed Jul 30, 2024
commit 76a364f52c26dea47ca089b225d3ddf753e7bc10
6 changes: 2 additions & 4 deletions Tools/cases_generator/stack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,8 @@ def unused(defn: StackItem) -> "Local":

@staticmethod
def local(defn: StackItem) -> "Local":
if defn.is_array():
return Local(defn, False, True, True)
else:
return Local(defn, True, False, True)
array = defn.is_array()
return Local(defn, not array, array, True)

@staticmethod
def redefinition(var: StackItem, prev: "Local") -> "Local":
Expand Down