Skip to content

gh-121025: improve partialmethod.__repr__ #121033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 5 commits into from
Jun 26, 2024
+18 −10
Merged

gh-121025: improve partialmethod.__repr__ #121033

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec7824a
improve `partialmethod.__repr__`
picnixz Jun 26, 2024
d5ea97d
add tests
picnixz Jun 26, 2024
087b8e4
blurb
picnixz Jun 26, 2024
fca1458
re-use `partial.__repr__` implementation
picnixz Jun 26, 2024
94b9d69
fix regex
picnixz Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
re-use partial.__repr__ implementation
  • Loading branch information
@picnixz
picnixz committed Jun 26, 2024
commit fca145842c70b7d29165a0f0d28df1da3b35513a
15 changes: 7 additions & 8 deletions Lib/functools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,14 +373,13 @@ def __init__(self, func, /, *args, **keywords):
self.keywords = keywords

def __repr__(self):
module = self.__class__.__module__
typename = self.__class__.__qualname__
args = ", ".join(map(repr, self.args))
keywords = ", ".join(f"{k}={v!r}" for k, v in self.keywords.items())
arguments = ", ".join(filter(None, (args, keywords)))
if arguments:
return f"{module}.{typename}({self.func}, {arguments})"
return f"{module}.{typename}({self.func})"
cls = type(self)
module = cls.__module__
qualname = cls.__qualname__
args = [repr(self.func)]
args.extend(map(repr, self.args))
args.extend(f"{k}={v!r}" for k, v in self.keywords.items())
return f"{module}.{qualname}({', '.join(args)})"

def _make_unbound_method(self):
def _method(cls_or_self, /, *args, **keywords):
Expand Down