Skip to content

GH-73991: Support preserving metadata in pathlib.Path.copy() #120806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barneygale merged 15 commits into from
Jul 6, 2024
Merged

GH-73991: Support preserving metadata in pathlib.Path.copy() #120806

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ff025ff
GH-73991: Support preserving metadata in `pathlib.Path.copy()`
barneygale Jun 20, 2024
720a0e0
Test timestamps
barneygale Jun 20, 2024
c14d16f
Typos
barneygale Jun 21, 2024
f54925c
Use code from shutil.
barneygale Jun 21, 2024
b05256b
Tighten conditions.
barneygale Jun 21, 2024
ee2cd35
Merge branch 'main' into copy-metadata
barneygale Jun 23, 2024
da6cd5b
Merge branch 'main' into copy-metadata
barneygale Jun 24, 2024
211b861
Undo shutil changes.
barneygale Jun 24, 2024
8129c46
Remove some code that's now unused.
barneygale Jun 24, 2024
15cc3db
docstrings, re-order methods.
barneygale Jun 27, 2024
89dfad5
Skip retrieving metadata if we're unable to set it on the target.
barneygale Jun 27, 2024
d312469
Merge branch 'main' into copy-metadata
barneygale Jul 3, 2024
547a3c3
Fix double lookup.
barneygale Jul 3, 2024
f584643
Rename methods.
barneygale Jul 3, 2024
3206a89
Tweaks
barneygale Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into copy-metadata
  • Loading branch information
@barneygale
barneygale committed Jul 3, 2024
commit d31246907f67e9d9cc39dda34b3c8c380b5e6fd9
23 changes: 13 additions & 10 deletions Lib/pathlib/_local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@
except ImportError:
grp = None

from ._abc import UnsupportedOperation, PurePathBase, PathBase
from ._os import copyfile, file_metadata_keys, get_file_metadata, set_file_metadata
from ._os import (UnsupportedOperation, copyfile, file_metadata_keys,
get_file_metadata, set_file_metadata)
from ._abc import PurePathBase, PathBase


__all__ = [
Expand Down Expand Up @@ -795,14 +796,16 @@ def copy(self, target, *, follow_symlinks=True, preserve_metadata=False):
try:
target = os.fspath(target)
except TypeError:
if isinstance(target, PathBase):
# Target is an instance of PathBase but not os.PathLike.
# Use generic implementation from PathBase.
return PathBase.copy(self, target,
follow_symlinks=follow_symlinks,
preserve_metadata=preserve_metadata)
raise
copyfile(os.fspath(self), target, follow_symlinks)
if not isinstance(target, PathBase):
raise
else:
try:
copyfile(os.fspath(self), target, follow_symlinks)
return
except UnsupportedOperation:
pass # Fall through to generic code.
PathBase.copy(self, target, follow_symlinks=follow_symlinks,
preserve_metadata=preserve_metadata)

def chmod(self, mode, *, follow_symlinks=True):
"""
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.