gh-118710: IPv*Address class properties - #120698
Conversation
gpshead
left a comment
There was a problem hiding this comment.
Please add .. versionchanged:: 3.14 annotations to the Doc/library/ipaddress.rst description of these attributes mentioning that they are now available on the class as well as instances.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
gpshead, I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @gpshead: please review the changes made to this pull request. |
…4-45-38.gh-issue-118710.5GZZPX.rst
Some properties moved from the object to the class, see python/cpython#120698 Change-Id: I81927998586a4338b72da7e6238cad45874d2a06
Some properties moved from the object to the class, see python/cpython#120698 Change-Id: Ib26b4a33f9e157ac2d1be34e576bed008c3de230
IPv{4,6}Address.versionandmax_prefixlenavailable on classes, not just instances #118710📚 Documentation preview 📚:
library/ipaddress.html#ipaddress.IPv4Address.version