Skip to content

gh-79932: raise exception if frame.clear() is called on a suspended frame #111792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 7 commits into from
Nov 7, 2023
Merged

gh-79932: raise exception if frame.clear() is called on a suspended frame #111792

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
af0b965
gh-79932: deprecate clearing a suspended frame and add option to get …
iritkatriel Nov 6, 2023
0e570d0
update traceback module to use the new arg
iritkatriel Nov 6, 2023
d23dfb6
update docs for traceback
iritkatriel Nov 6, 2023
765e013
Revert "update docs for traceback"
iritkatriel Nov 6, 2023
07b480a
Revert "update traceback module to use the new arg"
iritkatriel Nov 6, 2023
4196b0a
revert deprecation, treat as bugfix
iritkatriel Nov 6, 2023
82c6341
tweak docs, remove repetition in test
iritkatriel Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "update traceback module to use the new arg" 
This reverts commit 0e570d0.
  • Loading branch information
@iritkatriel
iritkatriel committed Nov 6, 2023
commit 07b480a84a497ccf5c11d0840accf5fc4bb200fb
19 changes: 0 additions & 19 deletions Lib/test/test_traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2518,25 +2518,6 @@ def inner():
# Local variable dict should now be empty.
self.assertEqual(len(inner_frame.f_locals), 0)

def test_do_not_clear_frame_of_suspended_generator(self):
# See gh-79932

def f():
try:
raise TypeError
except Exception as e:
yield e
yield 42

def g():
yield from f()

gen = g()
e = next(gen)
self.assertIsInstance(e, TypeError)
traceback.clear_frames(e.__traceback__)
self.assertEqual(next(gen), 42)

def test_extract_stack(self):
def extract():
return traceback.extract_stack()
Expand Down
2 changes: 1 addition & 1 deletion Lib/traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ def clear_frames(tb):
"Clear all references to local variables in the frames of a traceback."
while tb is not None:
try:
tb.tb_frame.clear(True)
tb.tb_frame.clear()
except RuntimeError:
# Ignore the exception raised if the frame is still executing.
pass
Expand Down