Skip to content

gh-61199: Remove superfluous global statements from base64._b32{en,de}code()*#111785

Merged
zware merged 1 commit into
python:mainfrom
romuald:wip-base64-useless-global
Nov 7, 2023
Merged

gh-61199: Remove superfluous global statements from base64._b32{en,de}code()*#111785
zware merged 1 commit into
python:mainfrom
romuald:wip-base64-useless-global

Conversation

@romuald

@romuald romuald commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

Remove now useless "global" statements from the base32 encode / decode methods

None values where changed to a global dict by
4ce6faa

@ghost

ghost commented Nov 6, 2023

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

Remove now useless "global" statements from the base32 encode / decode
methods

None values where changed to a global dict by
4ce6faa
@romuald romuald force-pushed the wip-base64-useless-global branch from e07565c to 267abec Compare November 6, 2023 15:31
@gaogaotiantian

Copy link
Copy Markdown
Member

This may not need a separate issue, but a news entry would be good. You can use https://blurb-it.herokuapp.com/ to add news entry.

@zware zware changed the title Lib/base64.py: remove useless global statements gh-61199: Remove superfluous global statements from base64._b32{en,de}code()* Nov 7, 2023
@zware zware added the skip news label Nov 7, 2023
@zware zware requested review from FFY00 and pganssle November 7, 2023 18:37
@zware

zware commented Nov 7, 2023

Copy link
Copy Markdown
Member

No need for a NEWS entry, this should have literally no effect (though I'll leave it to @FFY00 and/or @pganssle to confirm that :) ).

@zware zware merged commit ea970fb into python:main Nov 7, 2023
hugovk pushed a commit to hugovk/cpython that referenced this pull request Nov 8, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants