Skip to content

gh-110014: Fix inconsistent struct definition in pycore_semaphore.h #110030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
colesbury wants to merge 1 commit into from
Closed

gh-110014: Fix inconsistent struct definition in pycore_semaphore.h #110030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-110014: Fix inconsistent struct definition in pycore_semaphore.h 
The pycore_semaphore.h header is included by Python/lock.c and
Python/parking_lot.c. The macro `_POSIX_SEMAPHORES` was not consistently
defined across the two files (due to a missing include of `<unistd.h>`)
leading to different struct definitions. The RHEL8 ppc64le LTO buildbot
correctly warned due to this issue.
  • Loading branch information
@colesbury
colesbury committed Sep 28, 2023
commit 6e0228b7438d258e90e20ab7ee1bd045e489411a
4 changes: 4 additions & 0 deletions Include/internal/pycore_semaphore.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
# error "Require native threads. See https://bugs.python.org/issue31370"
#endif

#ifndef MS_WINDOWS
# include <unistd.h> // _POSIX_SEMAPHORES
#endif

#if (defined(_POSIX_SEMAPHORES) && (_POSIX_SEMAPHORES+0) != -1 && \
defined(HAVE_SEM_TIMEDWAIT))
# define _Py_USE_SEMAPHORES
Expand Down