Skip to content

gh-102864: Remove access to f_locals in pdb #102865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaogaotiantian wants to merge 8 commits into from
+98 −20
Closed

gh-102864: Remove access to f_locals in pdb #102865

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1283c2f
Remove access to f_locals in pdb
gaogaotiantian Mar 21, 2023
fb82b6a
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 21, 2023
3d85f0a
Polish comments
gaogaotiantian Mar 21, 2023
d346454
Don't overload `format_stack_entry`
ambv Mar 22, 2023
f2587e6
Use proxy for all frames in pdb
gaogaotiantian Mar 22, 2023
e358cd8
Implemented proxy for Frame and Traceback
gaogaotiantian Mar 23, 2023
a70d520
Replace curframe_f_locals to curframe.f_locals
gaogaotiantian Mar 23, 2023
ee4e545
Add tests
gaogaotiantian Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Polish comments
  • Loading branch information
@gaogaotiantian
gaogaotiantian committed Mar 21, 2023
commit 3d85f0a3b52712e853cc17683fc5a584c4e33220
3 changes: 3 additions & 0 deletions Lib/pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1562,6 +1562,9 @@ def format_stack_entry(self, frame, lineno, f_locals, lprefix=': '):
or '<lambda>', the input arguments, the return value, and the
line of code (if it exists).

This function is overwritten because accessing frame.f_locals will
refresh the dictionary. We need to provide cached f_locals to avoid
reverting local variable changes to it
"""
import linecache, reprlib
filename = self.canonic(frame.f_code.co_filename)
Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1475,9 +1475,9 @@ def test_pdb_issue_gh_94215():
"""

def test_pdb_issue_gh_101673():
"""See GH-101673
"""See GH-101673 and GH-102864

Make sure ll won't revert local variable assignment
Make sure ll and switching frames won't revert local variable assignment

>>> def test_function():
... a = 1
Expand Down