Skip to content

gh-81371: implementing checking async generator methods #102129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wrongnull wants to merge 3 commits into from
Closed

gh-81371: implementing checking async generator methods #102129

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8c7489
implementing checking async generator methods
wrongnull Feb 21, 2023
f309fbd
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 22, 2023
d16fa1a
handle one more corner case
wrongnull Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
📜🤖 Added by blurb_it.
  • Loading branch information
@blurb-it
blurb-it[bot] authored Feb 22, 2023
commit f309fbdf38b07d16da95e114187a935150d4e69e
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2023-02-22-02-14-38.gh-issue-81371.tUo0u1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This PR may fix the issue 81371
Copy link
Copy Markdown
Member

@sobolevn sobolevn Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May? Or does it? Please, also specify what the issue is. These are user-facing notes. It must be clear without a github link.

Copy link
Copy Markdown
Contributor Author

@wrongnull wrongnull Feb 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May? Or does it? Please, also specify what the issue is. These are user-facing notes. It must be clear without a github link.

I'm not 100% sure if it does. In the original issue those methods just returns some awaitable objects that doesn't pass the check. And I fixed it, but only for this certain example (I will add the tests soon). The obstacle is that I don't know if there are similar functions somewhere in the inerpreter. I'm not an internals expert. It would be great if you or someone else could suggest me such places.