Skip to content

importlib doc: Fix required Python version of an example#10118

Merged
vstinner merged 1 commit into
python:masterfrom
e-kwsm:fix-docs
Nov 5, 2018
Merged

importlib doc: Fix required Python version of an example#10118
vstinner merged 1 commit into
python:masterfrom
e-kwsm:fix-docs

Conversation

@e-kwsm

@e-kwsm e-kwsm commented Oct 26, 2018 •
edited by vstinner
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@e-kwsm
[Docs] Fix required version of an example of importlib
a99f421 
§31.5.6.3. Importing a source file directly
`module_from_spec` is new in 3.5
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 26, 2018
aixtools
aixtools suggested changes Oct 26, 2018
View reviewed changes

@aixtools aixtools left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is self-explanatory, but it reads asif this function did not exist in Python-3.4. If it did not exist, clearly a documentation bug that needs correcting.

However, IHMO, if this is a change only because Python3-3.5 is "newer" this should not be modified without a issue number explaining why "pretending" older versions did not support this is wise.

@e-kwsm

e-kwsm commented Oct 28, 2018

Copy link
Copy Markdown
Contributor Author

Maybe this is self-explanatory, but it reads asif this function did not exist in Python-3.4

Actually module_from_spec is new in 3.5.

@e-kwsm e-kwsm mentioned this pull request Oct 28, 2018
Closed
@vstinner

vstinner commented Oct 28, 2018

Copy link
Copy Markdown
Member

@e-kwsm first created PR #10030 but there was a blocker issue on CIs. I asked him to create a new PR instead.

@matrixise

matrixise commented Nov 4, 2018

Copy link
Copy Markdown
Member

@aixtools I suppose @e-kwsm has updated to 3.5 because 3.4 will be in EOL in 4 months.

@vstinner vstinner merged commit 16c8a53 into python:master Nov 5, 2018
@miss-islington

miss-islington commented Nov 5, 2018

Copy link
Copy Markdown
Contributor

Thanks @e-kwsm for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Nov 5, 2018

Copy link
Copy Markdown

GH-10345 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2018
@e-kwsm @miss-islington
[Docs] Fix required version of an example of importlib (pythonGH-10118)
6282461 
§31.5.6.3. Importing a source file directly: `module_from_spec` is new in Python 3.5.
(cherry picked from commit 16c8a53)

Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Nov 5, 2018

Copy link
Copy Markdown

GH-10346 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2018
@e-kwsm @miss-islington
[Docs] Fix required version of an example of importlib (pythonGH-10118)
f15ed2b 
§31.5.6.3. Importing a source file directly: `module_from_spec` is new in Python 3.5.
(cherry picked from commit 16c8a53)

Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>
@vstinner

vstinner commented Nov 5, 2018

Copy link
Copy Markdown
Member

Actually module_from_spec is new in 3.5.

Reference: https://docs.python.org/dev/library/importlib.html#importlib.util.module_from_spec

@vstinner

vstinner commented Nov 5, 2018

Copy link
Copy Markdown
Member

@aixtools I suppose @e-kwsm has updated to 3.5 because 3.4 will be in EOL in 4 months.

Read again the PR, the doc is just wrong. The PR fix it.

miss-islington added a commit that referenced this pull request Nov 5, 2018
@miss-islington @e-kwsm
[Docs] Fix required version of an example of importlib (GH-10118)
91a19c9 
§31.5.6.3. Importing a source file directly: `module_from_spec` is new in Python 3.5.
(cherry picked from commit 16c8a53)

Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Nov 5, 2018
@miss-islington @e-kwsm
[Docs] Fix required version of an example of importlib (GH-10118)
47a940e 
§31.5.6.3. Importing a source file directly: `module_from_spec` is new in Python 3.5.
(cherry picked from commit 16c8a53)

Co-authored-by: E Kawashima <e-kwsm@users.noreply.github.com>
@e-kwsm e-kwsm deleted the fix-docs branch November 6, 2018 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@aixtools aixtools aixtools requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@e-kwsm @vstinner @matrixise @miss-islington @bedevere-bot @aixtools @the-knights-who-say-ni