Add PEP 751 - #1848
Conversation
FFY00
left a comment
There was a problem hiding this comment.
Looks good, I just have a couple comments.
FFY00
left a comment
There was a problem hiding this comment.
Here are the reference changes.
Co-authored-by: Filipe Laíns 🇵🇸 <filipe.lains@gmail.com>
Co-authored-by: Filipe Laíns 🇵🇸 <filipe.lains@gmail.com>
Co-authored-by: Filipe Laíns 🇵🇸 <filipe.lains@gmail.com>
|
@FFY00 thanks for all of the references! I had to insert blank lines and then I went through and replaced every place I could think of with a reference. 😁 |
|
It's weird that the linkcheck job gets stuck for 48 minutes while on |
Along the way, ignore a troublesome URL that's slowing down link checking significantly.
|
@FFY00 I took your reformat idea to try and keep the HTML page from having so much horizontal scroll, but I also indenting subtables for ease of reading. |
|
@webknjaz looks like adding that URL to the ignore list did the trick to make CI fast again! PTAL. |
willingc
left a comment
There was a problem hiding this comment.
Thanks @brettcannon. Looking good.
|
@webknjaz anything I can do to help merge this? Support is getting released in various tools, but they are all working from the PEP at the moment. |
|
Hey, sorry. I never got to dedicating adequate amount of time to review this but since you got other approvals, I'll just skim through the patch and merge if there's nothing that stands out. |
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
|
@webknjaz I think I addressed all your comments; PTAL. |
webknjaz
left a comment
There was a problem hiding this comment.
@brettcannon thanks!
P.S. Plz prefer rebasing in this repo in the future since merge queues are set up to use natural merge and merging in the opposite direction causes "foxtrots".
📚 Documentation preview 📚: https://python-packaging-user-guide--1848.org.readthedocs.build/en/1848/