Skip to content

When publishing to PyPI, your username should be __token__ - #1037

Closed
danfunk wants to merge 1 commit into
pypa:mainfrom
danfunk:main
Closed

When publishing to PyPI, your username should be __token__#1037
danfunk wants to merge 1 commit into
pypa:mainfrom
danfunk:main

Conversation

@danfunk

@danfunk danfunk commented Jan 5, 2022

Copy link
Copy Markdown

I found I had to add this for the tutorial to work properly. Otherwise flawless, thank you!

…__, I found I had to add this for the tutorial to work properly. Otherwise flawless, thank you!
@danfunk
danfunk requested a review from webknjaz as a code owner January 5, 2022 00:46

@webknjaz webknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this but I prefer only specifying the required fields. The reason is that the action defaults to __token__ and it was designed to only need an explicit username when the end-users actually need to use passwords and not tokens (for example, when they want to upload to something like devpi.

Are there any reasons not to keep the example simple as it is now?

@webknjaz

webknjaz commented Jan 5, 2022

Copy link
Copy Markdown
Member

for the tutorial to work properly

If you've faced problems, I don't believe that they were caused by an implicit __token__. But my guess would be that you may have copied the token into the secrets incorrectly (with trailing/leading whitespace or something else missing) — this happens sometimes and is a user error.

@danfunk

danfunk commented Jan 5, 2022

Copy link
Copy Markdown
Author

I agree that if the default value is __token__, it would better not to set it.
I went back, and everything worked fine this time when I did not set the user name. Sorry for the trouble.

@danfunk danfunk closed this Jan 5, 2022
@webknjaz

webknjaz commented Jan 5, 2022

Copy link
Copy Markdown
Member

No problems :) Voicing your concerns is no trouble at all!

If you want to contribute some tutorial improvements, it may be a good idea to update @master to be @release/v1, plus maybe bump other action versions, and drop --sdist+--wheel args from the build command to get the latest improvements it has related to them (or even drop all the args for simplicity).

@webknjaz webknjaz changed the title When publishing to Pipy, your username should be __token__ When publishing to PyPI, your username should be __token__ Jan 5, 2022

@Ririe91 Ririe91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

48808377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants