Skip to content

Update to v0.14.0-rc3#19

Merged
JordanMartinez merged 3 commits intopurescript-contrib:mainfrom
JordanMartinez:updateTo14
Dec 4, 2020
Merged

Update to v0.14.0-rc3#19
JordanMartinez merged 3 commits intopurescript-contrib:mainfrom
JordanMartinez:updateTo14

Conversation

@JordanMartinez
Copy link
Copy Markdown
Contributor

@JordanMartinez JordanMartinez commented Dec 3, 2020

thomashoneyman
thomashoneyman reviewed Dec 3, 2020
View reviewed changes
Comment thread src/Data/ArrayBuffer/Types.purs Outdated
@thomashoneyman
Copy link
Copy Markdown
Contributor

thomashoneyman commented Dec 3, 2020 

Run spago install
spago: 
↳ ./spago.dhall
  ↳ ./packages.dhall
    ↳ https://raw.githubusercontent.com/purescript/package-sets/prepare-0.14/src/packages.dhall sha256:04c542b4d44c644031baf6220f441718289302ff4d4f71d43d57887eb295cf26

Error: Import integrity check failed

Expected hash:

↳ 04c542b4d44c644031baf6220f441718289302ff4d4f71d43d57887eb295cf26

Actual hash:

↳ f9b49a477fcd822a7119413b689123f8e1694b0008c156971f1931751079a56f


2│       https://raw.githubusercontent.com/purescript/package-sets/prepare-0.14/src/packages.dhall sha256:04c542b4d44c644031baf6220f441718289302ff4d4f71d43d57887eb295cf26

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

JordanMartinez commented Dec 3, 2020

Yeah. This is because I updated numbers to include functions as a dependency. However, the SHA hash was from the package set before that change was made.

@thomashoneyman
Copy link
Copy Markdown
Contributor

thomashoneyman commented Dec 3, 2020

This looks good other than reverting the whitespace changes to the ci.yml file!

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

JordanMartinez commented Dec 4, 2020

I decided it was easier to rerun my script on a fresh copy and update it to get rid of some of those unneeded commits.

@JordanMartinez JordanMartinez merged commit bb88e59 into purescript-contrib:main Dec 4, 2020
@JordanMartinez JordanMartinez deleted the updateTo14 branch December 4, 2020 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JordanMartinez @thomashoneyman