Merged
Conversation
hdgarrood
approved these changes
Sep 16, 2020
Contributor
hdgarrood
left a comment
There was a problem hiding this comment.
I would be tempted to release this as a breaking change because it’s possible that someone is relying on the more restricted current type signature for type inference to work. It is quite unlikely, admittedly.
Member
|
I can't really think of a way this would break an existing inferred type 🤔. Are we going to be breaking this library for 0.14 anyway though? If so, then I guess waiting makes sense. |
Contributor
Member
|
Merging as part of upcoming 0.14 changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your response to Issue! 😀
I've made some modifications based on #130.
This is a change to the type definition only.
The constraints are loosened and compatibility with existing sources will be maintained.
Closes #130