Re-add Semigroup/Monoid Map instances with Warn#54
Merged
thomashoneyman merged 4 commits intopurescript:masterfrom Mar 23, 2022
JordanMartinez:re-add-map-instances
Merged
Re-add Semigroup/Monoid Map instances with Warn#54thomashoneyman merged 4 commits intopurescript:masterfrom JordanMartinez:re-add-map-instances
thomashoneyman merged 4 commits intopurescript:masterfrom
JordanMartinez:re-add-map-instances
Conversation
Contributor
Author
|
We might want to get more feedback on this before merging. |
Member
|
Want to copy/paste that last comment over to Discourse? |
Contributor
Author
|
Sure. I've copied it over there. |
thomashoneyman
approved these changes
Mar 18, 2022
Member
thomashoneyman
left a comment
There was a problem hiding this comment.
👍, but we should leave this for another week to see if anyone has a comment wrt the warnings.
Contributor
Author
|
This PR will have been open for a week as of tomorrow (Wednesday). Since there's been no objection to dropping the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Addresses #36
Checklist: