Skip to content

Fix typo in CoreFn traversal function #4561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f-f merged 4 commits into from
Mar 24, 2026
+3 −1
Merged

Fix typo in CoreFn traversal function #4561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65776bb
Fix typo in traversal function
drathier Dec 29, 2024
3d5c106
Add changelog entry
drathier Feb 14, 2025
8a7d745
Add myself to list of contributors
drathier Feb 14, 2025
43c7df7
Merge branch 'master' into patch-1
f-f Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.d/internal_fix-typo-in-traversal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* Fix typo in CoreFn.Traversals.traverseCoreFn which caused it to not recurse into Let bodies
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ If you would prefer to use different terms, please use the section below instead
| [@xgrommx](https://github.com/xgrommx) | Denis Stoyanov | [MIT license] |
| [@zudov](https://github.com/zudov) | Konstantin Zudov | [MIT license] |
| [@roryc89](https://github.com/roryc89) | Rory Campbell | [MIT license] |
| [@drathier](https://github.com/drathier) | Drathier | [MIT license] |


### Contributors using Modified Terms
Expand Down
2 changes: 1 addition & 1 deletion src/Language/PureScript/CoreFn/Traversals.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ traverseCoreFn f g h i = (f', g', h', i')
g' (Abs ann name e) = Abs ann name <$> g e
g' (App ann v1 v2) = App ann <$> g v1 <*> g v2
g' (Case ann vs alts) = Case ann <$> traverse g vs <*> traverse i alts
g' (Let ann ds e) = Let ann <$> traverse f ds <*> g' e
g' (Let ann ds e) = Let ann <$> traverse f ds <*> g e
g' e = pure e

h' (LiteralBinder a b) = LiteralBinder a <$> handleLiteral h b
Expand Down
Loading