Skip to content

Allow ide module rebuilds without touching fs output/cache-db continued#4399

Merged
purefunctor merged 8 commits intopurescript:masterfrom
i-am-the-slime:master
Oct 30, 2022
Merged

Allow ide module rebuilds without touching fs output/cache-db continued#4399
purefunctor merged 8 commits intopurescript:masterfrom
i-am-the-slime:master

Conversation

@i-am-the-slime
Copy link
Copy Markdown
Contributor

@i-am-the-slime i-am-the-slime commented Oct 11, 2022 •
edited
Loading

Takes over from #4362
Closes #4362

Checklist:

  • Added a file to CHANGELOG.d for this PR (see CHANGELOG.d/README.md)
  • Added myself to CONTRIBUTORS.md (if this is my first contribution)
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@i-am-the-slime
Copy link
Copy Markdown
Contributor Author

i-am-the-slime commented Oct 11, 2022

@JordanMartinez I addressed the comments you had in #4362

JordanMartinez
JordanMartinez approved these changes Oct 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@purefunctor
Copy link
Copy Markdown
Member

purefunctor commented Oct 20, 2022

Mind adding a CHANGELOG.d entry to this as well?

@i-am-the-slime
Copy link
Copy Markdown
Contributor Author

i-am-the-slime commented Oct 20, 2022

@purefunctor sure.
Not sure how to add @wclr to contributors (I have no licence info).

@JordanMartinez
Copy link
Copy Markdown
Contributor

JordanMartinez commented Oct 27, 2022

@wclr Since this PR builds on your work and you did not specify a license under which your contributions were made in your former PRs, could you clarify what license you would use?

@wclr
Copy link
Copy Markdown
Contributor

wclr commented Oct 28, 2022

could you clarify what license you would use

Whatever is most common to use for this purpose, I hardly would like to be a legal person. -)

@purefunctor
Copy link
Copy Markdown
Member

purefunctor commented Oct 29, 2022

@wclr The majority of the CONTRIBUTORS.md entries use the MIT license, so we can go with that 😄

If you could add this @i-am-the-slime, I can merge this and close #4362. Thanks a lot again!

@JordanMartinez
Copy link
Copy Markdown
Contributor

JordanMartinez commented Oct 30, 2022

The license issue has been addressed. @purefunctor Mind approving this so we can merge?

@purefunctor purefunctor merged commit b7e0596 into purescript:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@purefunctor purefunctor purefunctor approved these changes

+1 more reviewer

@JordanMartinez JordanMartinez JordanMartinez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@i-am-the-slime @purefunctor @JordanMartinez @wclr