Skip to content

Refer to binary using local-doc-root workaround#4139

Merged
JordanMartinez merged 2 commits intopurescript:masterfrom
JordanMartinez:fixBinaryBuilds
Jul 7, 2021
Merged

Refer to binary using local-doc-root workaround#4139
JordanMartinez merged 2 commits intopurescript:masterfrom
JordanMartinez:fixBinaryBuilds

Conversation

@JordanMartinez
Copy link
Copy Markdown
Contributor

Description of the change

Fixes #4138.

Since v0.14.3 was already tagged, how do you want to handle this situation?


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Added myself to CONTRIBUTORS.md (if this is my first contribution)
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@thomashoneyman
Copy link
Copy Markdown
Member

It was tagged so recently (and without binaries) that I think we can delete the tag and tag a new release.

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

The release and tag have both been deleted

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

CI builds. Can I get an approval, so I can get this merged?

@hdgarrood
Copy link
Copy Markdown
Contributor

I think this is fine for now, especially since the old release has now been deleted, but just for future reference - we don’t know what kind of automation people might have with tags and releases and repo mirrors and so on, so in the future I would prefer to err on the side of not modifying existing tags. In this case I would have created a new v0.14.4 tag instead, and a small note in the changelog that v0.14.3 isn’t a real release.

@hdgarrood
Copy link
Copy Markdown
Contributor

Does using --haddock affect the size of the resulting binary? I’m now wondering if the binary we get will include docs somehow where it didn’t previously, causing the binary to be larger. I can’t see why else it would end up in a separate directory. If so I think the correct fix may be to avoid --haddock entirely, at least for release builds.

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

we don’t know what kind of automation people might have with tags and releases and repo mirrors and so on, so in the future I would prefer to err on the side of not modifying existing tags. In this case I would have created a new v0.14.4 tag instead, and a small note in the changelog that v0.14.3 isn’t a real release.

Makes sense. Mind if I add that to the RELEASE_GUIDE.md in case this should occur again?

Does using --haddock affect the size of the resulting binary?

I'm looking into that right now.

@hdgarrood
Copy link
Copy Markdown
Contributor

Adding this to RELEASE_GUIDE.md sounds like a great idea 👍

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

# v0.14.2
ls -ls purs.bin 
48408 -rwxr-xr-x 1 jordan jordan 49561488 Jun  5 12:18 purs.bin

# binary built from this PR
$ ls -ls purs 
48500 -rwxr-xr-x 1 jordan jordan 49650640 Jul  6 17:55 purs
Comparision
49,561,488
49,650,640

The difference is 89,152

@hdgarrood
Copy link
Copy Markdown
Contributor

I think we need to be comparing the old CI script with the new one when run against the same code. What do you get if you revert only the changes in ci/build.sh but leave everything else alone?

@hdgarrood
Copy link
Copy Markdown
Contributor

If the difference turns out to less than 100KB though then I think that’s safe to ignore.

@JordanMartinez
Copy link
Copy Markdown
Contributor Author

$ ls -ls purs 
48496 -rwxr-xr-x 1 jordan jordan 49650640 Jul  6 18:39 purs

Seems to be the same binary.

@hdgarrood
Copy link
Copy Markdown
Contributor

Thanks for checking!

@JordanMartinez JordanMartinez merged commit c1f9ccc into purescript:master Jul 7, 2021
@JordanMartinez JordanMartinez deleted the fixBinaryBuilds branch July 7, 2021 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI doesn't currently build binaries

3 participants