Json compat tests - #3497
Merged
Merged
Conversation
natefaubion
approved these changes
Dec 26, 2018
dariooddenino
pushed a commit
to dariooddenino/purescript
that referenced
this pull request
Jan 18, 2019
* Switch psc-publish tests to use hspec * Add tests for json compatibility refs purescript#2655, purescript#3494
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #2655, #3494
Adds tests to make sure that we don't accidentally break the json format. I'm not certain that these tests will check every constructor for the relevant data types, but this is much better than nothing at least. I've also updated the psc-publish tests to use hspec.