Fix isUnquotedKey check to allow reserved names - #3487
Merged
Conversation
Fixes #3482. We have allowed reserved names (like `data` or `type`) to be used as record labels without being quoted since #699 was resolved. This commit makes the `isUnquotedKey` function aware of this, having the effect that these labels are no longer unnecessarily quoted in error messages. For example, if we enter > {} :: { data :: Int } in the repl, we now receive: Error found: Type of expression lacks required label data. while checking that expression {} has type { data :: Int } whereas previously, `data` would have been quoted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3482. We have allowed reserved names (like
dataortype) tobe used as record labels without being quoted since #699 was resolved.
This commit makes the
isUnquotedKeyfunction aware of this, having theeffect that these labels are no longer unnecessarily quoted in error
messages. For example, if we enter
in the repl, we now receive:
whereas previously,
datawould have been quoted.