Conversation
Since it is only used for ProperName values at all but one call site, refactor to require that the argument is a ProperName rather than any old Text.
Fixes #3481; the check for whether a string represents a valid JS identifier was previously too permissive, i.e. it would allow through some strings are not valid as JS identifiers, leading to invalid syntax in the generated JS. For example, a string beginning with a digit is not a valid JS identifier but it was previously considered to be by the codegen phase of the compiler.
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3481. I've also included a commit with a small refactoring and improvement of some docs: in particular, I've removed a the now-misleading comment about what is done with symbols, because
Identvalues no longer contain symbols since we started requiring symbols to be aliases for named functions. I'd suggest reviewing each commit separately.