Fix isUnquotedKey, fixes #3479 - #3480
Merged
Merged
Conversation
Fixes labels not being quoted in error messages in some cases where they
should have been. For example:
Input code:
```
test :: { "Oops" :: Int }
test = { }
```
Before:
```
Type of expression lacks required label Oops.
while checking that expression {}
has type { Oops :: Int
}
in value declaration test
```
After:
```
Type of expression lacks required label "Oops".
while checking that expression {}
has type { "Oops" :: Int
}
in value declaration test
```
At the time of writing, there is just this one use of `isUnquotedKey`
throughout the entire compiler, so the refactoring I've done here is
safe.
Contributor
Author
|
🎉 thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes labels not being quoted in error messages in some cases where they
should have been. For example:
Input code:
Before:
After:
At the time of writing, there is just this one use of
isUnquotedKeythroughout the entire compiler, so the refactoring I've done here is
safe.
There doesn't appear to be a good way to test this, so I haven't added tests.